Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in TPE #237

Closed
wants to merge 1 commit into from

Conversation

COLDTURNIP
Copy link

Reference Issues/PRs

Fixes #236

What does this implement/fix? Explain your changes.

While TPE reviews the trial parameters before making suggestions, the historical internal parameter should be protected under storage's mutex.

@c-bata
Copy link
Owner

c-bata commented Sep 8, 2023

@COLDTURNIP Thank you for reporting the bug and creating a patch.

I have recently resumed maintenance and upon reviewing your PR, I noticed that while it does address the issue at hand, it could potentially cause an increase in SQL queries when using the RDB backend, which might lead to a degradation in performance.

To address this, I have prepared a separate PR (#246) that tackles the same issue but without additional SQL queries, ensuring a better performance. I am grateful for your understanding and once again, thank you for your input and dedication.

@c-bata c-bata closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent map r/w in TPE
2 participants