Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Octkit for Github API #97

Open
nkapolcs opened this issue Mar 21, 2020 · 3 comments
Open

Use Octkit for Github API #97

nkapolcs opened this issue Mar 21, 2020 · 3 comments
Labels
priority:backlog

Comments

@nkapolcs
Copy link
Contributor

nkapolcs commented Mar 21, 2020 •
edited
Loading

Prerequisite: #25

Use octokit/rest instead of fetch the github api.
@nkapolcs nkapolcs mentioned this issue Mar 21, 2020
Merged
4 tasks
@gomorizsolt
Copy link
Collaborator

Please make sure it's possible to use the package without authentication.

Authentication is optional for some REST API endpoints accessing public data, but is required for GraphQL queries.

https://octokit.github.io/rest.js/v17#authentication

It's supposed to be used that way according to the docs.

@thisismydesign
Copy link
Member

We should prefer no-auth at this point

@gomorizsolt
Copy link
Collaborator

We should prefer no-auth at this point

Yep, sure, it was just a side note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thisismydesign @nkapolcs @gomorizsolt