-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 25 gh projects imptovement infer tech from language and topics #94
Issue 25 gh projects imptovement infer tech from language and topics #94
Conversation
…h-projects-imptovement-infer-tech-from-language-and-topics
For now, I display the same as the medium, but maybe we could use icons if you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, overall looks good!
For now, I display the same as the medium, but maybe we could use icons if you prefer.
From my side, it's fine as-is for now.
On second thought, how about making the logic more "reactish"? :) const [languageBadges, setLanguageBadges] = useState([]);
useEffect(() => {
if (githubRepoLanguages.data) {
const sum = Object.keys(githubRepoLanguages.data).reduce(...);
// filter the badges according to the treshold
const badges = // ...
setLanguageBadges(badges);
}
}, [githubRepoLanguages.data]); Please make sure there's no infinite re-renders(because |
This should follow the |
Thanks for suggesting. Now I solved it with hooks. Resolved by a72c1f4 |
Resolved by a72c1f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really get the logic inside of useEffect()
, left a few questions.
Thanks! Resolved by 0d74fcc |
Issue #25
Currently GH project tech info in configurable by hand, but we could extend it so that it can auto-infer some things.
Changes:
Preview: