Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 72 online presence icons and links #90

Merged
merged 9 commits into from
Mar 3, 2020
Merged

Issue 72 online presence icons and links #90

merged 9 commits into from
Mar 3, 2020

Conversation

nkapolcs
Copy link
Contributor

@nkapolcs nkapolcs commented Feb 6, 2020 •
edited
Loading

Issue #72
Add a component which displays the online presence icons.

Prerequisite: #86 is merged to master

Changes:

  • add separate configuration entry for "Online presence icons"
  • add configuration entry for Online presence
  • display online presence links on the top right below day/night mode switch
  • merge master
  • add documentation
  • create SocialIcons component

@nkapolcs nkapolcs changed the title [WIP] Issue 72 online presence icons and links Issue 72 online presence icons and links Feb 20, 2020
thisismydesign
thisismydesign reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks. Attach a picture please.

@nkapolcs
Copy link
Contributor Author

Should I create a hover effects to the buttons?

Peek 2020-02-20 23-21

@thisismydesign
Copy link
Member

Thanks for the picture.

Should I create a hover effects to the buttons?

No need for now.

@nkapolcs nkapolcs self-assigned this Feb 29, 2020
gomorizsolt
gomorizsolt reviewed Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@gomorizsolt gomorizsolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left a few comments.

src/components/Header/Header.js Outdated Show resolved Hide resolved
src/components/UI/SocialIcons/SocialIcons.js Outdated Show resolved Hide resolved
src/components/Header/Header.js Outdated Show resolved Hide resolved
gomorizsolt
gomorizsolt approved these changes Mar 3, 2020
View reviewed changes
Copy link
Collaborator

@gomorizsolt gomorizsolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side.

@nkapolcs nkapolcs merged commit eb258c2 into master Mar 3, 2020
@nkapolcs nkapolcs deleted the issue-72_online-presence-icons-and-links branch March 3, 2020 21:58
@nkapolcs nkapolcs mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomorizsolt gomorizsolt gomorizsolt approved these changes

@thisismydesign thisismydesign Awaiting requested review from thisismydesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkapolcs @thisismydesign @gomorizsolt