Fix for alliedmodders#972 when a static is used by a stock Function

This adds stock functions to the maybe used set which seems most appropriate. We can then mark all of the functions they refer too as maybe used also.
c0rp3n · Jun 9, 2024 · e99733c · e99733c
1 parent 2213b8e
commit e99733c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/compiler/semantics.cpp b/compiler/semantics.cpp
@@ -2876,6 +2876,10 @@ bool Semantics::CheckFunctionDeclImpl(FunctionDecl* info) {
     if (info->as<MemberFunctionDecl>())
         maybe_used_.emplace_back(info);
 
+    // We never warn about unused stock functions.
+    if (info->is_stock())
+        maybe_used_.emplace_back(info);
+
     auto fwd = info->prototype();
     if (fwd && fwd->deprecate() && !info->is_stock())
         report(info->pos(), 234) << info->name() << fwd->deprecate();

diff --git a/tests/compile-only/ok-static-used-by-stock.inc b/tests/compile-only/ok-static-used-by-stock.inc
@@ -0,0 +1,7 @@
+static void SomeHelperFunction()
+{}
+
+stock void HelpMe()
+{
+	SomeHelperFunction();
+}
diff --git a/tests/compile-only/ok-static-used-by-stock.sp b/tests/compile-only/ok-static-used-by-stock.sp
@@ -0,0 +1,5 @@
+// warnings_are_errors: true
+#include "ok-static-used-by-stock.inc"
+
+public void main()
+{}