-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and process Commands - closes #100 #101
base: master
Are you sure you want to change the base?
Conversation
Could you describe a bit more what this PR is intended to resolve? It'll be particularly interesting to see when this is ran. I was wondering whether this was pre or post but looking at #100 this looks like it's actually in the middle. Is that correct? |
@ekohl That's correct. My use case is to actually use combination of two tools bump(2)version and towncrier. I am aiming for the following flow:
This way I'll have
|
I think this feature goes a long way, but will remain too limited for many use cases. For example, a command might need to take a part value as an argument (e.g. Other tools specializing in 'running commands' are better suited to do such things. Makefiles come to mind, and I've have had good experiences with invoke (version <1.3.0 due to its issue Just automate the the release steps (bump, towncrier, git commit, git tag, build, publish, push, ...) there and you're set. |
This requires a decision on whether this is desired (#100). If approved, this merge request will need documentation and unit tests before it can be merged. |
@fizyk -- thanks for the time you spent on this and helping us think through this. Unfortunately, unless @ekohl and @florisla strongly disagree I think adding subcommands to bump2version would make it much too bloated. Basically, we're taking the fact that bump2version knows how to git-tag and then extending that fact to make it do something before git-tag happens. That begs the question: why not git-tag yourself? IMHO we should stick to "do one thing and do it well" and not add more stuff that's hard to maintain. @florisla's suggestion above is how I would go about doing this. Happy to discuss further... |
I suppose ther few things to adjust and fix, for now the basic assumptions are working for me, will adjuist the changeset as well as see the tests later