Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non default search and replace of omitted optional value #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Non default search and replace of omitted optional value #160

wants to merge 2 commits into from

Conversation

andersonbrands
Copy link

No description provided.

@andersonbrands andersonbrands changed the title Develop Non default search and replace of omitted optional value Sep 9, 2020
@florisla
Copy link
Collaborator

florisla commented Jan 22, 2021

To recap, version v0.0 (0.0-prod) is not properly bumped to v0.1-dev. That's a serious bug.

While investigating your fix, I've found an alternative way to fix this: drop the found_required variable in version_part.py VersionConfig._serialize().

But I'm not sure which of the two approaches is most robust.

I'll add a test case where also the serialization {major} is valid.
Then, test all combinations of config file version (0, 0.0 or 0.0-prod) with three different files, each
having a longer serialize -- these should bump to 1, 1.0 and 1.0-dev respectively.

@florisla florisla self-assigned this Jan 22, 2021
@florisla florisla added this to the Next release milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants