Raise exception with error output if CalledProcessError when tagging. #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if tagging fails (ex: version were changed manually and an old tag was attempted to be re-used),
subprocess.CalledProcessError
is raised without helpful information.Proposing changing this to raise a custom exception,
TaggingFailureException
, with thesubprocess.CalledProcessError.returncode
and.output
to help diagnosis the issue.This will also prevent a successful exit code from occurring if tagging fails, as noted in #224.
Ran
make test
successfully, except for Python 3.5 which is unavailable on the image: