Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate disableSSLRedirect with sslRedirect #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nilathedragon
Copy link
Contributor

For issue #102

Should we log a deprecation notice if we detect ingress objects using the old annotation?
Could be done easily in matcher.go if we add a zap logger to the plugin.

@Embraser01
Copy link
Member

Should we log a deprecation notice if we detect ingress objects using the old annotation?
Could be done easily in matcher.go if we add a zap logger to the plugin.

Fine by me

@nilathedragon
Copy link
Contributor Author

image

Hmm putting it there spams the logs quite a bit. It would certainly bring the message across 😅

@Embraser01
Copy link
Member

image

Hmm putting it there spams the logs quite a bit. It would certainly bring the message across 😅

It may be too much spam 😅, the convert function may be called many times so I think we should log this warning in another way, like only if config changed. That would mean having a list of deprecation messages to log somewhere 🤔

I'm not sure on how to do that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants