Skip to content

Commit

Permalink
fix lint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Assem-Hafez committed Apr 5, 2024
1 parent 2f437d3 commit 820e79b
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 21 deletions.
2 changes: 2 additions & 0 deletions .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ version: '3.8'
services:
# Update this to the name of the service you want to work with in your docker-compose.yml file
cadence_web:
env_file:
- .docker_env
# Uncomment if you want to override the service's Dockerfile to one in the .devcontainer
# folder. Note that the path of the Dockerfile and context is relative to the *primary*
# docker-compose.yml file (the first in the devcontainer.json "dockerComposeFile"
Expand Down
3 changes: 3 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "next/core-web-vitals"
}
17 changes: 0 additions & 17 deletions src/components/test-table/test-table.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function DomainPageHeader() {
return 0;
/* return domainPageQueryParamsConfig
.reduce((result, { key, defaultValue }) => queryParams[key] === defaultValue ? result : result + 1, 0); */
}, [queryParams]);
}, [/* queryParams */]);

const clustersOptions = CLUSTERS_CONFIGS.map(({ clusterName }) => ({ label: clusterName, id: clusterName }));
const clusterValue = clustersOptions.filter(({ id }) => id === queryParams.clusterName)
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/use-page-query-params/use-page-query-params.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function usePageQueryParams(
const search = useMemo(() => {
if (typeof window !== 'undefined') return window.location.search;
return searchQueryParams.toString();
}, [searchQueryParams, typeof window !== 'undefined' && window.location.search]);
}, [searchQueryParams]);

const values = useMemo(() => {
const urlQueryParamsObject = queryString.parse(search);
Expand All @@ -49,7 +49,7 @@ export default function usePageQueryParams(
rerender(newHref)
}
},
[router, configs, search]
[extraConfig?.replace, extraConfig?.pageRerender, configs, search, router.replace, router.push, pathname, rerender]
);

return [values, setter];
Expand Down
2 changes: 1 addition & 1 deletion src/utils/grpc/grpc-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,4 @@ const clusterServicesMethods = CLUSTERS_CONFIGS.reduce((result, c) => {
return result;
}, {} as { [k: string]: any })

export default { clusterMethods: clusterServicesMethods }
export const clusterMethods = clusterServicesMethods;

0 comments on commit 820e79b

Please sign in to comment.