Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared table component #763

Open
wants to merge 7 commits into
base: release/4.0.0
Choose a base branch
from

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Dec 13, 2024

Summary

  • Move search & filters logic to separate WorkflowsHeader component
  • Move table logic to separate WorkflowsTable component
  • Move useListWorkflows to shared/hooks

Test plan

Updated unit tests + ran locally.

@adhityamamallan adhityamamallan force-pushed the shared-table branch 2 times, most recently from 07bd04e to ad03652 Compare December 13, 2024 12:14
@adhityamamallan adhityamamallan marked this pull request as ready for review December 20, 2024 11:30

import DOMAIN_WORKFLOWS_PAGE_SIZE from '../config/domain-workflows-page-size.config';
import { type UseListWorkflowsParams } from '../domain-workflows.types';
import { type WorkflowsFiltersValues } from '../workflows-header/workflows-header.types';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type doesn't really make sense now that I reorganized the code, but where can we have it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant