Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES]: #234 and #235 #236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

BUZZARDGTA
Copy link

@BUZZARDGTA BUZZARDGTA commented Sep 27, 2023

Basically you where doing a lookup on the different possible Errors possible, while I am saying: "Oh, it's not 300 or 200? Fine then it's an error."

I'm sure you will cringe me for my ui.js code, but I tried my best to works with your (imo outdated code for this new algorythm) to make it working on your actual core.

Feel free to change the code as you prefer it, I've just put this here because it contains a fix for both of these issues.

@BUZZARDGTA
Copy link
Author

BUZZARDGTA commented Sep 28, 2023

Okay while scanning my huge database with this pull request, I've noticed that the "Errors" contains a problem, basically almost or all urls have been displayed in the UI as "Errors", the "Errors" counter itself is fine.
I know exactly what's the issue and how to fix it, it's my ui.js that contains default Errors.
I've tought about a solution where i'd keep using your old source code but creates an Errors flag: "STATUS.DOWN_OTHER" or something like that. It will be pretty cool normally since it's gonna match the previous source codes using the switch js function.

But I have really big troubles to work with the STATUS.JS as they are just a list of static const, I will probably ends up by removing it completely at some points

Anyways, gtg work for now :D

@BUZZARDGTA
Copy link
Author

BUZZARDGTA commented Sep 28, 2023

Fixed, I have pretty much reduced a lot from the file status.js, not sure how you will like it or not.
I basically made it 4 dedicated modes now instead of custom error codes like you did, now it's:

  • OK
  • REDIRECTION
  • NOT_OK
  • UNKNOWN

Note: I have removed the feature that scans on "GET" after "HEAD" failed. (it was not implemented from you anyways); and since now we anyways only scan using "GET" in the first place, that feature doesn't even make sense to keep anymore.

@BUZZARDGTA
Copy link
Author

Little hotfix because I'm a clown 🤡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant