Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data attributes instead of JSON #11

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Use data attributes instead of JSON #11

merged 1 commit into from
Nov 20, 2023

Conversation

xjensen
Copy link
Collaborator

@xjensen xjensen commented Nov 20, 2023

Remove script tag from API response. We'll use data attributes on the HTML instead of embedding JSON.

Copy link

Widget preview page.

(You may need to wait a minute or two for the latest preview to appear. This page will expire when the PR is merged.)

@xjensen xjensen merged commit 5318a70 into main Nov 20, 2023
2 checks passed
@xjensen xjensen deleted the scriptless-dataset branch November 20, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant