Skip to content

Commit

Permalink
Merge pull request #987 from cagov/release/1.0.12-butte
Browse files Browse the repository at this point in the history
Release/1.0.12 butte
  • Loading branch information
zakiya authored Dec 8, 2023
2 parents de4fb38 + 5b412c8 commit d653456
Show file tree
Hide file tree
Showing 33 changed files with 156 additions and 88 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module.exports = {
'arrow-parens': 'off',
'implicit-arrow-linebreak': 'off',
'function-paren-newline': 'off',
'wc/require-listener-teardown': 'off',
},
ignorePatterns: [
'**/dist/*',
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-aws-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@master
- name: Use Node.js 16.13.1
- name: Use Node.js 21
uses: actions/setup-node@v1
with:
node-version: 16.13.1
node-version: 21
- name: Build Site
run: |
npm install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@master
- name: Use Node.js 16.13.1
- name: Use Node.js 21
uses: actions/setup-node@v1
with:
node-version: 16.13.1
node-version: 21
- name: Build Site
run: |
npm install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-previews.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@master
- name: Use Node.js 16.13.1
- name: Use Node.js 21
uses: actions/setup-node@v1
with:
node-version: 16.13.1
node-version: 21
- name: Get branch name (merge)
if: github.event_name != 'pull_request'
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@master
- name: Use Node.js 16.13.1
- name: Use Node.js 21
uses: actions/setup-node@v1
with:
node-version: 16.13.1
node-version: 21
- name: Build Site
run: |
npm install
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# California Design System

## 1.0.12

- Security fixes
- Fix for google translate [#985](https://github.com/cagov/design-system/issues/985)
- Documentation updates


## 1.0.11

- Dozens of dependabot flagged package versioning updates
- Migrate from 11ty v1 to v2.
- Update the backend for the homepage partner signup form to run on AWS and use personal tokens since airtable is dropping plain api key support next year. #963

## 1.0.10

- #915 CSS insertion moved into JavaScript Custom Element constructors.
Expand Down
4 changes: 0 additions & 4 deletions components/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

This directory contains State of California design system components in research, alpha, beta and production stages of development. More documentation is available on the <a href="https://designsystem.webstandards.ca.gov">design system site</a>.

## README template

[Notion Template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

## File structure

Each component is an npm package so has a package.json as well as readme and changelog files written in markdown and a test config in the root directory:
Expand Down
2 changes: 0 additions & 2 deletions components/accordion/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/back-to-top/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/feature-card/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/highlight-section/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,4 @@ Expected definition is:

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/link-grid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/link-icon/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,4 @@ Requires a `main` tag and activates on `a` tags. Automatically detects links and

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/page-alert/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/page-feedback/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,4 @@ Values that this component will post:

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/page-navigation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/pagination/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,4 @@ It also accepts optional strings for all the text so it can be used in multiple

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/regulatory-outline/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,4 @@ This component requires `ol.cagov-regulatory-outline`. It will not work with `ul

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/site-footer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/site-header/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,4 @@ This component requires the following content assets and configuration variables

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
3 changes: 3 additions & 0 deletions components/site-navigation/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Site navigation changelog

## 3.0.3
* Fix bug where nav stopped working when GTranslate is present. [985](https://github.com/cagov/design-system/issues/985).

## 3.0.2
* Different strategy for the Android fix. Looks at prior window.innerWidth, rather than setting a flag. Fixes possible issue with multiple rapidfire calls to resize.

Expand Down
4 changes: 1 addition & 3 deletions components/site-navigation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ The instructions assume familiarity with [npm](https://npmjs.com) package manage
We recommend using a build system and bundling your JavaScript and CSS for faster performance. If you do not use a build system, you can include the code from our CDN with link and script tags.

```html
<link rel="stylesheet" href="https://cdn.designsystem.webstandards.ca.gov/components/ds-site-navigation/v3.0.2/dist/index.css">
<link rel="stylesheet" href="https://cdn.designsystem.webstandards.ca.gov/components/ds-site-navigation/v3.0.3/dist/index.css">
<script type="module" src="https://cdn.designsystem.webstandards.ca.gov/components/ds-site-navigation/v3.0.0/dist/index.js"></script>
```

Expand Down Expand Up @@ -371,8 +371,6 @@ For example, in the WordPress CMS integration, content editors can manage menu l

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)

¹ To use `import`, files must be served from a [webserver](https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_is_a_web_server) such as Apache, Nginx, or [http-server](https://www.npmjs.com/package/http-server). The `file://` protocol will cause CORS errors in some browsers.
2 changes: 1 addition & 1 deletion components/site-navigation/dist/index.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/site-navigation/dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ class CAGovSiteNavigation extends window.HTMLElement {
}
const menuComponent = this;
menu.addEventListener('click', function addingClickListener(event) {
if (event.target.nodeName !== 'A') {
if (event.target.nodeName !== 'A' && event.target.nodeName !== 'FONT') {
event.preventDefault();
}
const expandedEl = this.querySelector('.expanded-menu-section');
Expand Down
7 changes: 5 additions & 2 deletions components/site-navigation/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cagov/ds-site-navigation",
"version": "3.0.2",
"version": "3.0.3",
"description": "",
"main": "dist/index.js",
"type": "module",
Expand Down Expand Up @@ -28,5 +28,8 @@
},
"dependencies": {
"rollup-plugin-import-css": "^3.0.2"
},
"volta": {
"node": "21.2.0"
}
}
}
2 changes: 1 addition & 1 deletion components/site-navigation/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ class CAGovSiteNavigation extends window.HTMLElement {
}
const menuComponent = this;
menu.addEventListener('click', function addingClickListener(event) {
if (event.target.nodeName !== 'A') {
if (event.target.nodeName !== 'A' && event.target.nodeName !== 'FONT') {
event.preventDefault();
}
const expandedEl = this.querySelector('.expanded-menu-section');
Expand Down
2 changes: 0 additions & 2 deletions components/skip-to-content/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,4 @@ This component uses the following data attributes. We provide this information t

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/statewide-footer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,4 @@ These links are managed by [CA.gov](http://ca.gov). Additional information about

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/statewide-header/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,4 @@ The official tag is a string that may require that you verify that it translates

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/step-list/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,4 @@ This component uses the `ol.cagov-step-list` class. It will work on `ul` element

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
2 changes: 0 additions & 2 deletions components/table/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,4 @@ none.

- [Component information](https://github.com/cagov/design-system/blob/main/components/README.md)

- [Component README template](https://www.notion.so/odi-engineering/Component-documentation-template-2da3975cc0954174ace43004d151451c)

- [Unit tests](https://github.com/cagov/design-system/blob/main/components/UNIT-TESTS.md)
Loading

0 comments on commit d653456

Please sign in to comment.