Pagination display fix. @cagov/ds-pagination version 2.0.4 #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview site available at jbum-pagination-patch.pr.designsystem.webstandards.ca.gov. |
|
@jon-grant-state-ca-gov @kkoryaka Can you review/comment/test/merge? We have some site updates that depend on it |
jon-grant-state-ca-gov
approved these changes
Aug 20, 2024
kkoryaka
approved these changes
Aug 20, 2024
|
Just realized our contribution documentation is in a private Coda. Going to add them to this project's wiki. CDT folks you can determine what you want to do with them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a display issue with pagination buttons. The current code displays the following when there are 4 available pages.
Notice that on page 1, Page 3 is mysteriously dropped. On Page 4, an ellipsis is displayed in place of a single page (ellipsis should only be used for 2 or more pages).
There are similar issues with 5 page, 6 page, and 7 page displays. Here is a 7 page display.
Notice that an ellipsis is shown in place of a single page, and page 6 is missing.
This patch shows the ellipsis in cases where it represents 2 or more pages, and shows a single page in its place, when it is appropriate to do, fixing all the above issues.