Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PHP 8.1+ #369

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Update for PHP 8.1+ #369

wants to merge 2 commits into from

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Dec 27, 2022

First stab at #368

It will also require test harness to be fixed up for 8.1+

Declaration of PHP_CodeSniffer\Tests\TestSuite::run(?PHPUnit\Framework\TestResult $result = null) must be compatible with PHPUnit\Framework\TestSuite::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult

As well as (follow-ups?):

  • Move tests into tests/ with proper autoload-dev instead of part of autoload

@dereuromark
Copy link
Member Author

I enabled for now the full set of mult-line declarations, just for testing
We can redude this once we are ready for merging if it is too disruptive and only keep 1 of the 3 pairs

For now the pressing question is how to get the tests working on modern versions of dependencies.

@dereuromark
Copy link
Member Author

Anyone any ideas on the blocker of tests getting green again?

@ADmad ADmad mentioned this pull request Apr 9, 2023
@LordSimal
Copy link

Whats the state of this PR?

@dereuromark
Copy link
Member Author

This looks like it needs a bit of rework now.
I would still like to see it added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants