Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attribute rules #396

Merged
merged 1 commit into from
Aug 13, 2024
Merged

add attribute rules #396

merged 1 commit into from
Aug 13, 2024

Conversation

LordSimal
Copy link

@LordSimal LordSimal commented Aug 10, 2024

This makes sure that something like this is not allowed:

#[DataProvider('irregularCreateTableProvider')] public function mymethod(): void

This also forces attribtues to be added bellow the docblock

Refs: cakephp/migrations#736

@LordSimal LordSimal added this to the 5.x milestone Aug 10, 2024
@LordSimal
Copy link
Author

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these make sense. The ordering and sniffs seem like rules that won't come up that often as we don't use attributes in the framework yet.

@dereuromark dereuromark merged commit 04860c9 into 5.x Aug 13, 2024
5 checks passed
@dereuromark dereuromark deleted the 5.x-attributes branch August 13, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants