Fix generating unique index creation calls.

Uses the actual unique index constraints to generate indexes, that way the correct index name is being used, and it won't create indexes that do not actually exist in the schema that is being snapshotted (this might have been done to emulate MySQL, where indexes are automatically created for foreign keys).
cakephp · Sep 22, 2023 · 1a185c8 · 1a185c8
1 parent aaf8729
commit 1a185c8
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 13 deletions.
diff --git a/tests/comparisons/Migration/pgsql/test_snapshot_auto_id_disabled_pgsql.php b/tests/comparisons/Migration/pgsql/test_snapshot_auto_id_disabled_pgsql.php
@@ -190,7 +190,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();

diff --git a/tests/comparisons/Migration/pgsql/test_snapshot_not_empty_pgsql.php b/tests/comparisons/Migration/pgsql/test_snapshot_not_empty_pgsql.php
@@ -159,7 +159,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();

diff --git a/tests/comparisons/Migration/sqlite/test_snapshot_auto_id_disabled_sqlite.php b/tests/comparisons/Migration/sqlite/test_snapshot_auto_id_disabled_sqlite.php
@@ -112,7 +112,7 @@ public function up(): void
                     'slug',
                 ],
                 [
-                    'name' => 'categories_slug_unique',
+                    'name' => 'categories_unique_slug',
                     'unique' => true,
                 ]
             )
@@ -181,7 +181,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();
@@ -254,7 +254,7 @@ public function up(): void
                     'slug',
                 ],
                 [
-                    'name' => 'products_slug_unique',
+                    'name' => 'products_unique_slug',
                     'unique' => true,
                 ]
             )
@@ -320,7 +320,7 @@ public function up(): void
                     'article_id',
                 ],
                 [
-                    'name' => 'special_tags_article_unique',
+                    'name' => 'UNIQUE_TAG2',
                     'unique' => true,
                 ]
             )

diff --git a/tests/comparisons/Migration/sqlite/test_snapshot_not_empty_sqlite.php b/tests/comparisons/Migration/sqlite/test_snapshot_not_empty_sqlite.php
@@ -96,7 +96,7 @@ public function up(): void
                     'slug',
                 ],
                 [
-                    'name' => 'categories_slug_unique',
+                    'name' => 'categories_unique_slug',
                     'unique' => true,
                 ]
             )
@@ -150,7 +150,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();
@@ -209,7 +209,7 @@ public function up(): void
                     'slug',
                 ],
                 [
-                    'name' => 'products_slug_unique',
+                    'name' => 'products_unique_slug',
                     'unique' => true,
                 ]
             )
@@ -267,7 +267,7 @@ public function up(): void
                     'article_id',
                 ],
                 [
-                    'name' => 'special_tags_article_unique',
+                    'name' => 'UNIQUE_TAG2',
                     'unique' => true,
                 ]
             )

diff --git a/tests/comparisons/Migration/sqlite/test_snapshot_plugin_blog_sqlite.php b/tests/comparisons/Migration/sqlite/test_snapshot_plugin_blog_sqlite.php
@@ -96,7 +96,7 @@ public function up(): void
                     'slug',
                 ],
                 [
-                    'name' => 'categories_slug_unique',
+                    'name' => 'categories_unique_slug',
                     'unique' => true,
                 ]
             )

diff --git a/tests/comparisons/Migration/test_snapshot_auto_id_disabled.php b/tests/comparisons/Migration/test_snapshot_auto_id_disabled.php
@@ -200,7 +200,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();

diff --git a/tests/comparisons/Migration/test_snapshot_not_empty.php b/tests/comparisons/Migration/test_snapshot_not_empty.php
@@ -165,7 +165,7 @@ public function up(): void
                     'product_id',
                 ],
                 [
-                    'name' => 'orders_product_category_idx',
+                    'name' => 'product_category',
                 ]
             )
             ->create();