Import Db/Table package and get tests passing #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import the Db/Table package from phinx and get the tests passing. My plan here is to import all of the 'data transfer' objects from phinx and get them referencing each other. Once that is complete, we'll need to import the Plan and Migration wrappers. This will form the core of the API compatibility with phinx. The adapter layer can be replaced by a mix of Cake's Database package and some more dialect style platform wrappers. Finally we'll need to provide the same CLI interface that migrations has always given.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the Db/Table package from phinx and get the tests passing.
My plan here is to import all of the 'data transfer' objects from phinx and get them referencing each other. Once that is complete, we'll need to import the Plan and Migration wrappers.
This will form the core of the API compatibility with phinx. The adapter layer can be replaced by a mix of Cake's Database package and some more dialect style platform wrappers.
Finally we'll need to provide the same CLI interface that migrations has always given.
I've made this pull request against the
no-phinxbranch which will be where we iterate on this idea without disrupting a maintenance/release branch.