Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import adapter base classes and MysqlAdapter #670

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Import adapter base classes and MysqlAdapter #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7dc3971
Import and do renames on adapter interfaces and exceptions
markstory Dec 25, 2023
11bfe30
Import MySQL adapter
markstory Dec 26, 2023
005a024
Fix cs
markstory Dec 26, 2023
4559efe
Fix a bunch of psalm errors.
markstory Dec 26, 2023
bc23881
Fix most of the psalm errors and update the baseline
markstory Dec 27, 2023
6b8d237
Clean up phpstan output.
markstory Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,24 @@ parameters:
path: src/Command/BakeMigrationSnapshotCommand.php

-
message: "#^Parameter \\#1 \\$table of method Phinx\\\\Db\\\\Adapter\\\\AdapterInterface\\:\\:createTable\\(\\) expects Phinx\\\\Db\\\\Table\\\\Table, Migrations\\\\Db\\\\Table\\\\Table given\\.$#"
message: "#^Offset 'id' on non\\-empty\\-array\\<string, mixed\\> in isset\\(\\) always exists and is not nullable\\.$#"
count: 2
path: src/Db/Plan/Plan.php
path: src/Db/Adapter/MysqlAdapter.php

-
message: "#^Parameter \\#1 \\$table of method Phinx\\\\Db\\\\Adapter\\\\AdapterInterface\\:\\:executeActions\\(\\) expects Phinx\\\\Db\\\\Table\\\\Table, Migrations\\\\Db\\\\Table\\\\Table given\\.$#"
count: 2
path: src/Db/Plan/Plan.php

-
message: "#^Parameter \\#2 \\$actions of method Phinx\\\\Db\\\\Adapter\\\\AdapterInterface\\:\\:executeActions\\(\\) expects array\\<Phinx\\\\Db\\\\Action\\\\Action\\>, array\\<Migrations\\\\Db\\\\Action\\\\Action\\> given\\.$#"
count: 2
path: src/Db/Plan/Plan.php
message: "#^Parameter \\#4 \\$options of method Migrations\\\\Db\\\\Adapter\\\\PdoAdapter\\:\\:createPdoConnection\\(\\) expects array\\<int, mixed\\>, array\\<int\\|string, mixed\\> given\\.$#"
count: 1
path: src/Db/Adapter/MysqlAdapter.php

-
message: "#^Parameter \\#2 \\$columns of method Phinx\\\\Db\\\\Adapter\\\\AdapterInterface\\:\\:createTable\\(\\) expects array\\<Phinx\\\\Db\\\\Table\\\\Column\\>, array\\<Migrations\\\\Db\\\\Table\\\\Column\\> given\\.$#"
count: 2
path: src/Db/Plan/Plan.php
message: "#^Right side of && is always true\\.$#"
count: 1
path: src/Db/Adapter/MysqlAdapter.php

-
message: "#^Parameter \\#3 \\$indexes of method Phinx\\\\Db\\\\Adapter\\\\AdapterInterface\\:\\:createTable\\(\\) expects array\\<Phinx\\\\Db\\\\Table\\\\Index\\>, array\\<Migrations\\\\Db\\\\Table\\\\Index\\> given\\.$#"
count: 2
path: src/Db/Plan/Plan.php
message: "#^Access to an undefined property PDO\\:\\:\\$connection\\.$#"
count: 1
path: src/Db/Adapter/PdoAdapter.php

-
message: "#^Possibly invalid array key type Cake\\\\Database\\\\Schema\\\\TableSchemaInterface\\|string\\.$#"
Expand Down
23 changes: 10 additions & 13 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,16 @@
<code>setInput</code>
</PossiblyNullReference>
</file>
<file src="src/Db/Plan/Plan.php">
<InvalidArgument>
<code><![CDATA[$newTable->getColumns()]]></code>
<code><![CDATA[$newTable->getColumns()]]></code>
<code><![CDATA[$newTable->getIndexes()]]></code>
<code><![CDATA[$newTable->getIndexes()]]></code>
<code><![CDATA[$newTable->getTable()]]></code>
<code><![CDATA[$newTable->getTable()]]></code>
<code><![CDATA[$update->getActions()]]></code>
<code><![CDATA[$update->getActions()]]></code>
<code><![CDATA[$update->getTable()]]></code>
<code><![CDATA[$update->getTable()]]></code>
</InvalidArgument>
<file src="src/Db/Adapter/AbstractAdapter.php">
<RedundantPropertyInitializationCheck>
<code><![CDATA[isset($this->output)]]></code>
</RedundantPropertyInitializationCheck>
</file>
<file src="src/Db/Adapter/MysqlAdapter.php">
<RedundantCondition>
<code>$opened</code>
<code>is_array($newColumns)</code>
</RedundantCondition>
</file>
<file src="src/TableFinderTrait.php">
<PossiblyUndefinedArrayOffset>
Expand Down
Loading