Migrations builtin backend #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm opting to create duplicate code that optimizes for code deletion instead of brevity as I hope to remove half the code soon.
markstory
force-pushed
the
migrations-builtin-backend
branch
from
db45e7e
to
31c5295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the current logic from
Migrations, and create an adapter between phinx and the 'builtin' backends. This approach optimizes for isolation between the backends until we have more confidence that it is correct.The interface compatibility is ensured by tests. We likely have coverage gaps in these tests. We'll soon find out.
Part of #647