Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stan #734

Merged
merged 2 commits into from
Aug 8, 2024
Merged

update stan #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44266ad
update stan
LordSimal Aug 8, 2024
6e06793
Update src/Db/Adapter/SqliteAdapter.php
LordSimal Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .phive/phars.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<phive xmlns="https://phar.io/phive">
<phar name="phpstan" version="1.10.56" installed="1.10.56" location="./tools/phpstan" copy="false"/>
<phar name="psalm" version="5.20.0" installed="5.20.0" location="./tools/psalm" copy="false"/>
<phar name="phpstan" version="1.11.9" installed="1.11.9" location="./tools/phpstan" copy="false"/>
<phar name="psalm" version="5.25.0" installed="5.25.0" location="./tools/psalm" copy="false"/>
</phive>
6 changes: 4 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ includes:

parameters:
level: 7
checkMissingIterableValueType: false
checkGenericClassInNonGenericObjectType: false
paths:
- src/
bootstrapFiles:
- tests/bootstrap.php
ignoreErrors:
- identifier: missingType.iterableValue
- identifier: missingType.generics

3 changes: 0 additions & 3 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,5 @@
<code><![CDATA[$this->regexpParseColumn]]></code>
<code><![CDATA[$this->regexpParseField]]></code>
</ArgumentTypeCoercion>
<TypeDoesNotContainType>
<code>empty($indexes[$indexName])</code>
</TypeDoesNotContainType>
</file>
</files>
3 changes: 2 additions & 1 deletion src/Command/MigrationsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static function defaultName(): string
/**
* Array of arguments to run the shell with.
*
* @var array<string>
* @var list<string>
*/
public array $argv = [];

Expand Down Expand Up @@ -198,6 +198,7 @@ public function run(array $argv, ConsoleIo $io): ?int
$name = explode(' ', $name);

array_unshift($argv, ...$name);
/** @var list<string> $argv */
Copy link
Contributor Author

@LordSimal LordSimal Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the easiest way to ignore this error since we just provide an array but symfony wants a list<string>|null

$this->argv = $argv;

return parent::run($argv, $io);
Expand Down
4 changes: 2 additions & 2 deletions src/Db/Adapter/SqliteAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,8 +1098,8 @@ protected function calculateNewTableColumns(string $tableName, string|false $col
}
}

$selectColumns = array_filter($selectColumns, 'strlen');
$writeColumns = array_filter($writeColumns, 'strlen');
$selectColumns = array_filter($selectColumns, fn ($value) => $value !== '');
$writeColumns = array_filter($writeColumns, fn ($value) => $value !== '');
$selectColumns = array_map([$this, 'quoteColumnName'], $selectColumns);
$writeColumns = array_map([$this, 'quoteColumnName'], $writeColumns);

Expand Down
Loading