Import most of Phinx\Util\Util #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most but not all. I've only included the methods we're currently relying on in migrations. This is another step towards decoupling from phinx for the new backend.
it isn't used internally and I don't see a reason to maintain it.
It is unused internally.
I won't be able to fully refactor it away. There are conventions for migration files that Inflector does not replicate.
The test stubs for Util don't need to adhere to coding standards as they contain migration files from phinx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most but not all. I've only included the methods we're currently relying on in migrations. This is another step towards decoupling from phinx for the new backend.