Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration version and name to pending actions error #2289

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add migration version and name to pending actions error #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3578775
2288 - Add migration version and name to pending actions error
ajibarra Jun 7, 2024
aef52b4
2288 - Update postFlightCheckFail test to remove dynamic message
ajibarra Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Phinx/Migration/AbstractMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ public function postFlightCheck(): void
{
foreach ($this->tables as $table) {
if ($table->hasPendingActions()) {
throw new RuntimeException('Migration has pending actions after execution!');
throw new RuntimeException(sprintf('Migration %s_%s has pending actions after execution!', $this->getVersion(), $this->getName()));
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Phinx/Migration/AbstractMigrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ public function testTableMethod()
public function testPostFlightCheckFail()
{
// stub migration
$migrationStub = $this->getMockForAbstractClass('\Phinx\Migration\AbstractMigration', ['mockenv', 20230102030405]);
$migrationStub = $this->getMockForAbstractClass('\Phinx\Migration\AbstractMigration', ['mockenv', 20230102030405], 'PostFlightCheck');

$adapterStub = $this->getMockBuilder('\Phinx\Db\Adapter\MysqlAdapter')
->setConstructorArgs([[]])
Expand All @@ -280,7 +280,7 @@ public function testPostFlightCheckFail()
$table->addColumn('column1', 'integer', ['null' => true]);

$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Migration has pending actions after execution!');
$this->expectExceptionMessage('Migration 20230102030405_PostFlightCheck has pending actions after execution!');

$migrationStub->postFlightCheck();
}
Expand Down
Loading