Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept version strings in dot separated format. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndm2
Copy link
Contributor

@ndm2 ndm2 commented Apr 18, 2022

This allows to use version strings like 4.next instead of 4-next for the search_version docs theme config option, unifying the format used in all the different places, so no special format has to be remembered.

This change is backwards compatible, the various docs config files can be updated once this change is live and there should be no downtime.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #16 (9cd21f8) into master (ce6b947) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        67        67           
===========================================
  Files              6         6           
  Lines            282       282           
===========================================
  Hits             282       282           
Impacted Files Coverage Δ
src/Model/Index/SearchIndex.php 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant