Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of wizard factories #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JMSoler7
Copy link

@JMSoler7 JMSoler7 commented Mar 9, 2021

No description provided.

In order to avoid getting wizard from pool (which forces to get session_id from create method and then instantiate
it), a new class called WizardFactory is created.

With this initial approach the user can define Wizard as a factory and not taking care of session. The purpose of
this class is lay the grundwork to allow manage ModelViews and state transistions in the future.
@JMSoler7 JMSoler7 changed the title WIP wizard Initial implementation of wizard factories Mar 9, 2021
Copy link

@maltalk maltalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to add python 3.9 tests. Other than that I find it a good initial implementation.

@JMSoler7 JMSoler7 requested a review from tura0 March 10, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants