Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alert for JSON Files Larger than 3MB #149

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

acupoftee
Copy link

@acupoftee acupoftee commented Sep 27, 2019

This PR addresses Issue #22

  • My approach for this iteration was to add an alert for large JSON files. This would be good feedback for the user when trying to parse JSON.
  if ( bodyChildren.length !== 1 || pre.tagName !== 'PRE' ||  jsonLength > (3000000)) {
        if (jsonLength) {
            alert('JSON Formatter Error: Cannot format JSON longer than 3MB');
        }
        // Disconnect the port (without even having used it)
          port.disconnect() ;
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant