Strip out Express typeof check from JSONP #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Express server adds a 'typeof' check to JSONP responses to reduce client error noise (and an empty comment for security). See: https://github.com/strongloop/express/blob/4.13.3/lib/response.js#L312-L314 Strip this out before checking whether or not the response is JSONP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express server adds a 'typeof' check to JSONP responses to reduce client error noise (and an empty comment for security). See:
https://github.com/strongloop/express/blob/4.13.3/lib/response.js#L312-L314
Example output:
http://ibl.api.bbci.co.uk/?callback=notReal
The extension does not currently recognise such output as JSONP. This pull request fixes that by stripping out the 'typeof' check before checking whether the response is valid. It closes #49.