Add km/h for windspeed #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be split into a PR upstream to pyowm to support km_h as a wind
unit and one here to reference that?
…On Thu, Jan 31, 2019, 01:43 Eduardo Elias ***@***.*** wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#19
Commit Summary
- Add km/h for windspeed
File Changes
- *M* README.md
<https://github.com/calzoneman/i3-weather/pull/19/files#diff-0> (1)
- *M* test_all_specifiers.sh
<https://github.com/calzoneman/i3-weather/pull/19/files#diff-1> (2)
- *M* weather.py
<https://github.com/calzoneman/i3-weather/pull/19/files#diff-2> (1)
Patch Links:
- https://github.com/calzoneman/i3-weather/pull/19.patch
- https://github.com/calzoneman/i3-weather/pull/19.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXiiCPaCNvqdkscobJ72D7vMXquCeHzks5vIrq2gaJpZM4ab7XX>
.
|
Makes sense. I will update this PR as soon as I get it accepted at pyowm |
calzoneman
reviewed
Feb 1, 2019
test_all_specifiers.sh
Outdated
| @@ -14,5 +14,5 @@ fi | |||
| .env/bin/python weather.py \ | |||
| --api-key $OWM_KEY \ | |||
| --city-id $OWM_CITY_ID \ | |||
| --format "{city}, {country}: {text}, {temp_f}°F ({temp_c}°C, {temp_k}K), Relative humidity {humidity}%, Wind: {wind_speed_mph} MPH ({wind_speed_ms} m/s) from {wind_direction}° ({wind_direction_arrow} {wind_direction_fuzzy}), Daylight from {sunrise} to {sunset}, Pressure {pressure} millibars" | |||
| --format "{city}, {country}: {text}, {temp_f}°F ({temp_c}°C, {temp_k}K), Relative humidity {humidity}%, Wind: {wind_speed_mph} MPH ({wind_speed_ms} m/s, {wind_spee_kmh} km/h) from {wind_direction}° ({wind_direction_arrow} {wind_direction_fuzzy}), Daylight from {sunrise} to {sunset}, Pressure {pressure} millibars" | |||
|
The change got merged into pyowm. May need to wait until next release (>2.10.0) to get merged |
|
Do you know when the new pyowm will be released? I hate to leave your PR sitting around if the pyowm dev isn't planning to release for a while. |
Sorry, but I have no idea. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.