Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location-verification: Alignment of errors with Commonalities #215

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Jun 20, 2024

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

  • Errors according to new Commonalities guidelines
  • Now all errors tested in test plan are explicitly indicated in the spec
  • Added some descriptions to make linter happy

Which issue(s) this PR fixes:

Fixes #214

- Now all errors tested in test plan are explicitly indicated in the spec
- Added some descriptions to make linter happy
@jlurien jlurien requested a review from bigludo7 as a code owner June 20, 2024 12:58
Copy link

github-actions bot commented Jun 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 4.61s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.79s
✅ YAML yamllint 3 0 0.57s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 added the Fall24 Meta-release Fall24 label Jul 1, 2024
@bigludo7 bigludo7 changed the title Alignment of errors with Commonalities location-verification: Alignment of errors with Commonalities Jul 2, 2024
@jlurien jlurien merged commit 977e738 into main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Meta-release Fall24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Location Verification with guidelines for error scenarios
3 participants