Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Authorization and authentication in info.description #217

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add Authorization and authentication in info.description #217

merged 4 commits into from
Jul 3, 2024

Conversation

maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Adds the Authorization and authentication to the info.description

Which issue(s) this PR fixes:

Fixes #212

@maxl2287 maxl2287 self-assigned this Jun 21, 2024
@maxl2287 maxl2287 added the documentation Improvements or additions to documentation label Jun 21, 2024
bigludo7
bigludo7 previously approved these changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@bigludo7 bigludo7 added the Fall24 Meta-release Fall24 label Jul 1, 2024
fernandopradocabrillo
fernandopradocabrillo reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just small cosmetic comments since the section hierarchy is not consistent across APIs.

code/API_definitions/geofencing-subscriptions.yaml Outdated Show resolved Hide resolved
code/API_definitions/location-retrieval.yaml Outdated Show resolved Hide resolved
code/API_definitions/location-verification.yaml Outdated Show resolved Hide resolved
bigludo7
bigludo7 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287
Copy link
Contributor Author

maxl2287 commented Jul 3, 2024

@bigludo7 shell I create a ticket on Commonalities for the section hierarchy of this chapter?

@bigludo7
Copy link
Collaborator

bigludo7 commented Jul 3, 2024

@bigludo7 shell I create a ticket on Commonalities for the section hierarchy of this chapter?

Hi @maxl2287 - Yes probably to fix this once. Thanks !

fernandopradocabrillo
fernandopradocabrillo approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks @maxl2287 !

@bigludo7 bigludo7 merged commit e96cac3 into camaraproject:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes

@bigludo7 bigludo7 bigludo7 approved these changes

@jlurien jlurien Awaiting requested review from jlurien jlurien is a code owner

Assignees

@maxl2287 maxl2287

Labels
documentation Improvements or additions to documentation Fall24 Meta-release Fall24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Authorization and authentication" - section in info.description
3 participants
@maxl2287 @bigludo7 @fernandopradocabrillo