-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling when the requested geofence area
cannot be covered
#224
Add handling when the requested geofence area
cannot be covered
#224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bigludo7 do you align with the TerminationReason? |
In DeviceStatus we have a label |
…e/geofencing-manage-unhandled-subscriptions # Conflicts: # code/API_definitions/geofencing-subscriptions.yaml
… subscription ended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with José suggestion
Co-authored-by: Jose Luis Urien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds handling when the provided subscription area cannot be covered or is too small to receive any notifications.
Which issue(s) this PR fixes:
Fixes #198