Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update errormessage for unsupported device identifieres #261

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update errormessage for unsupported device identifieres #261

wants to merge 5 commits into from

Conversation

maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Fixing a typo / mistake in the error for GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS

Which issue(s) this PR fixes:

Fixes #260

@maxl2287 maxl2287 self-assigned this Sep 26, 2024
bigludo7
bigludo7 previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
From a process perspective does it means that we have to do a new release @jlurien ?

jlurien
jlurien reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any change in the specs in the main branch we have to set versions to wip again

@jlurien
Copy link
Collaborator

jlurien commented Sep 27, 2024

LGTM From a process perspective does it means that we have to do a new release @jlurien ?

We have to decide if changes are worthy for a new release. I would wait until we have something really relevant, and in that case update all small things as well

@maxl2287
Copy link
Contributor Author

maxl2287 commented Oct 9, 2024

@jlurien & @bigludo7 I updated the version to "wip".
I guess we can then integrate it into the main, right? (if you are okay with it)

@jlurien jlurien mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlurien jlurien jlurien approved these changes

@bigludo7 bigludo7 Awaiting requested review from bigludo7 bigludo7 is a code owner

Assignees

@maxl2287 maxl2287

Labels
correction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small typo in GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS - example
3 participants
@maxl2287 @jlurien @bigludo7