Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TI API Rel 0.9.4: CR in LF format #240

Closed
wants to merge 2 commits into from

Conversation

FabrizioMoggio
Copy link
Collaborator

Carriage Return in LF format.

What type of PR is this?

Add one of the following kinds:

  • bug

What this PR does / why we need it:

CR should be in LF format while in Rel 0.9.3 it was in Windows format. I decided not to include this update in rel 0.9.3 otherwise every code line is effected and the modification were not visible anymore.

Carriage Return in LF format.
@FabrizioMoggio FabrizioMoggio changed the title Ver 0.9.4 CR in LF format TI API Rel 0.9.4: CR in LF format May 15, 2024
Copy link
Collaborator

@javierlozallu javierlozallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FabrizioMoggio I am not familiar with LF format versus Windows format and I don't find any differences with version 0.9.3, could you explain briefly?
Thank you.

previous upload was not correct
@FabrizioMoggio
Copy link
Collaborator Author

You can not see any difference because there are no differences in this 0.9.4 :-). Rel 0.9.3 was already actually using Carriage Return LF format. I just discovered that if you copy a file from GitHub using the "Copy RAW file" button, the Carriage Return is implemented in Windows format even if the original file has the Carriage Return in LF format. This confused me because I couldn't understand why the file was in Windows format. So I made the patch. So I can close this PR.

Screenshot 2024-05-16 115457

@FabrizioMoggio
Copy link
Collaborator Author

About the Image, on the left you can see Carriage Return as LF (Linux) and on the right they are implemented as CR.LF (Windows)

@FabrizioMoggio FabrizioMoggio deleted the DevelopCR branch June 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants