Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename EdgeCloud_LcM.yaml to Edge-Application-Management.yaml #244

Merged
merged 5 commits into from
May 27, 2024

Conversation

crissancas
Copy link
Collaborator

@crissancas crissancas commented May 20, 2024

New PR with corrections to pass Megalinter and Spectral tests,addition of X-Correlator and includes Consent Management

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

New PR with corrections to pass Megalinter and Spectral tests,addition of X-Correlator and includes Consent Management.
API Documentation included in the YAML and the exiting one renamed to *_Obsolete.md

Which issue(s) this PR fixes:

Fixes #192

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

New PR with corrections to pass Megalinter and Spectral tests,addition of X-Correlator and includes Consent Management
Copy link

github-actions bot commented May 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ JSON eslint-plugin-jsonc 1 0 0 1.41s
✅ JSON jsonlint 1 0 0.19s
✅ JSON prettier 1 1 0 0.95s
✅ JSON v8r 1 0 2.55s
✅ OPENAPI spectral 2 0 4.64s
✅ REPOSITORY git_diff yes no 0.54s
✅ REPOSITORY secretlint yes no 4.45s
✅ YAML yamllint 2 0 0.66s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@gunjald
Copy link
Collaborator

gunjald commented May 20, 2024

One observation with new name is that the usage of word "operations Management" may indicate to operation management functions as performed by service management role while the APIs that has been defined are more of the edge applications management. Any thoughts?

@javierlozallu
Copy link
Collaborator

One observation with new name is that the usage of word "operations Management" may indicate to operation management functions as performed by service management role while the APIs that has been defined are more of the edge applications management. Any thoughts?

It's a fair question and something we took into account, which is why we added the description:
`The Edge Operations Management API allows API consumers to manage the Lifecycle of an Application and Discover Edge Cloud Resources.’

But Edge Application Management is also an appropriate name, so if we all agree on that name we can go with it.

@gunjald
Copy link
Collaborator

gunjald commented May 20, 2024

To me Edge Application Management seems fine.

@javierlozallu javierlozallu changed the title Update and rename EdgeCloud_LcM.yaml to Edge-Operations-Management.yaml Update and rename EdgeCloud_LcM.yaml to Edge-Application-Management.yaml May 23, 2024
@javierlozallu
Copy link
Collaborator

To me Edge Application Management seems fine.

@gunjald
Change done! I also delete GSMA terminology to avoid telco specific language as @Kevsy suggested in #245

gunjald
gunjald previously approved these changes May 23, 2024
Copy link
Collaborator

@gunjald gunjald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Copy link
Collaborator

@gunjald gunjald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@javierlozallu javierlozallu merged commit 8c469b7 into main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants