Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAM API: change AppManifest version to string #305

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

gainsley
Copy link
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

Change AppManifest version from int to string, to allow version to be in semver format, i.e. "1.0.1", or like a docker tag, i.e. "latest" or "stable-1.0", or an integer as it was originally. Basically requiring it to an integer is too limiting.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

change AppManifest version field type from integer to string

Additional documentation

docs

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 1.3s
✅ JSON jsonlint 1 0 0.17s
✅ JSON prettier 1 1 0 0.97s
✅ JSON v8r 1 0 2.39s
✅ OPENAPI spectral 3 0 6.1s
✅ REPOSITORY git_diff yes no 0.5s
✅ REPOSITORY secretlint yes no 4.66s
✅ YAML yamllint 3 0 0.8s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@JoseMConde JoseMConde merged commit 1e906ee into main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants