-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMARA ICM-examples #148
CAMARA ICM-examples #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have deliberately took any details about how CAMARA might use authorization_details
in future out of the profile.
I propose to also omit the examples from this file here (which will go into the v0.2 release).
Why? We would otherwise need to discuss and decide about the examples now, as it could otherwise be that people start to implement it this way. For example we haven't decided if authorization_details will be used if there is only one purpose (we envision RAR for more complex scenarios). Within the examples for multiple purposes I have the impression that the use of "locations" isn't as intended in the RFC, but that's a discussion which doesn't belong here and now, as we need first to define which scenarios we want to cover business wise.
Co-authored-by: Ming Hui <[email protected]>
Co-authored-by: Ming Hui <[email protected]>
Co-authored-by: Elisabeth-Ericsson <[email protected]>
Co-authored-by: Ming Hui <[email protected]>
I think the examples document looks quite good. @hdamker is back on Monday and I assume that his change request was about removing the RAR examples. Not sure why github did not mark that change request as "outdated". Anyway, waiting for Herbert to confirm and approve. @Elisabeth-Ericsson and @mhfoo do you need further changes, more examples or would you please approve this PR? |
Co-authored-by: Shilpa Padgaonkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Co-authored-by: Shilpa Padgaonkar <[email protected]>
I have the impression that this PR is about to be finished. So, I removed the WIP. |
Your assumption is correct, my request is addressed with the removal of the RAR examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, requested changes are addressed.
Co-authored-by: Jesús Peña García-Oliva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Move CAMARA-ICM-examples.md from fork to this repo