-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of API version 1.0.0-rc.1 (don't merge, to be closed) #123
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Done for 401 & 403
number_verification.yaml seems to been uploaded as a new file in 435b7bd. GitHub is showing that all lines were replaced, which makes it difficult to see the actual changes, especially the ones from the following commits here in the PR. |
Co-authored-by: Herbert Damker <[email protected]>
Hi @hdamker, I'm trying to fix this but I can't commit into the PR. It seems that it's locked. As admin, do you have permissions to unlock it? Converting it to draft doesn't seem to work |
@fernandopradocabrillo I have no clue why this PR should have been locked, but I thought it is anyway easier to recreate the originally PR #121, but just against the correct base branch (i.e. What is left do do is to redo the following commits: But I would recommend to do them not in #126 but in a separate PR before the #126 get's merged and the release done. |
This PR shouldn't be merged but closed, it is replace by #126, but see also #123 (comment) |
Closing it and deleting the branch |
What type of PR is this?
Add one of the following kinds:
Note: this PR has exactly same contents than #121 that was closed because of branch issue
What this PR does / why we need it:
Generation of first release-candidate for NumberVerification API
This first release candidate r1.1 contains the definition and documentation of the release-candidate of the NumberVerification API v1.0.0-rc.1.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.