Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of API version 1.0.0-rc.1 (don't merge, to be closed) #123

Closed
wants to merge 8 commits into from

Conversation

bigludo7
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

Note: this PR has exactly same contents than #121 that was closed because of branch issue

What this PR does / why we need it:

Generation of first release-candidate for NumberVerification API

This first release candidate r1.1 contains the definition and documentation of the release-candidate of the NumberVerification API v1.0.0-rc.1.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented Jul 26, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.61s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.72s
✅ YAML yamllint 1 0 0.29s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7 bigludo7 requested a review from a team July 26, 2024 10:14
@bigludo7 bigludo7 removed the request for review from a team July 26, 2024 14:42
@bigludo7 bigludo7 requested a review from a team July 26, 2024 14:46
CHANGELOG.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Contributor

hdamker commented Jul 27, 2024

number_verification.yaml seems to been uploaded as a new file in 435b7bd.

GitHub is showing that all lines were replaced, which makes it difficult to see the actual changes, especially the ones from the following commits here in the PR.

@hdamker hdamker requested a review from a team July 27, 2024 17:41
Co-authored-by: Herbert Damker <[email protected]>
@fernandopradocabrillo fernandopradocabrillo marked this pull request as draft July 29, 2024 13:43
@fernandopradocabrillo
Copy link
Collaborator

number_verification.yaml seems to been uploaded as a new file in 435b7bd.

GitHub is showing that all lines were replaced, which makes it difficult to see the actual changes, especially the ones from the following commits here in the PR.

Hi @hdamker, I'm trying to fix this but I can't commit into the PR. It seems that it's locked. As admin, do you have permissions to unlock it? Converting it to draft doesn't seem to work

@hdamker
Copy link
Contributor

hdamker commented Jul 29, 2024

@fernandopradocabrillo I have no clue why this PR should have been locked, but I thought it is anyway easier to recreate the originally PR #121, but just against the correct base branch (i.e. main). Therefore I recreated the branch https://github.com/camaraproject/NumberVerification/tree/bigludo7-patch-2 and used it to open the new PR #126.
(It would have even been possible to just edit the base path in PR #121, but not after it was closed and I deleted the previous base path).

What is left do do is to redo the following commits:

83fd1a2, 65b1db0, and 73ee72f

But I would recommend to do them not in #126 but in a separate PR before the #126 get's merged and the release done.

@hdamker
Copy link
Contributor

hdamker commented Jul 29, 2024

This PR shouldn't be merged but closed, it is replace by #126, but see also #123 (comment)

@hdamker hdamker changed the title Release of API version 1.0.0-rc.1 Release of API version 1.0.0-rc.1 (don't merge, to be closed) Jul 29, 2024
@hdamker hdamker removed the request for review from a team July 29, 2024 15:27
@hdamker
Copy link
Contributor

hdamker commented Jul 29, 2024

What is left do do is to redo the following commits:

83fd1a2, 65b1db0, and 73ee72f

But I would recommend to do them not in #126 but in a separate PR before the #126 get's merged and the release done.

I've opened #127 for that.

@hdamker
Copy link
Contributor

hdamker commented Jul 30, 2024

Closing it and deleting the branch

@hdamker hdamker closed this Jul 30, 2024
@hdamker hdamker deleted the Number-Verification-MR-prep branch July 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants