Skip to content

Commit

Permalink
fix: vector_retriever (#1075)
Browse files Browse the repository at this point in the history
Co-authored-by: Wendong <[email protected]>
  • Loading branch information
Asher-hss and Wendong-Fan authored Oct 18, 2024
1 parent c44640f commit 9f9a7f9
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
7 changes: 7 additions & 0 deletions camel/retrievers/vector_retriever.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,13 @@ def query(
db_query = VectorDBQuery(query_vector=query_vector, top_k=top_k)
query_results = self.storage.query(query=db_query)

# If no results found, raise an error
if not query_results:
raise ValueError(
"Query result is empty, please check if "
"the vector storage is empty."
)

if query_results[0].record.payload is None:
raise ValueError(
"Payload of vector storage is None, please check the "
Expand Down
36 changes: 36 additions & 0 deletions test/retrievers/test_vector_retriever.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,39 @@ def test_query(vector_retriever):
results = vector_retriever.query(query, top_k=top_k)
assert len(results) == 1
assert results[0]['similarity score'] == '0.8'


# Test query with no results found
def test_query_no_results(vector_retriever):
query = "test query"
top_k = 1
# Setup mock behavior for vector storage query
vector_retriever.storage.load = Mock()
vector_retriever.storage.query.return_value = []

with pytest.raises(
ValueError,
match="Query result is empty, please check if the "
"vector storage is empty.",
):
vector_retriever.query(query, top_k=top_k)


# Test query with payload None
def test_query_payload_none(vector_retriever):
query = "test query"
top_k = 1
# Setup mock behavior for vector storage query
vector_retriever.storage.load = Mock()
vector_retriever.storage.query.return_value = [
Mock(similarity=0.8, record=Mock(payload=None))
]

with pytest.raises(
ValueError,
match=(
"Payload of vector storage is None, "
"please check the collection."
),
):
vector_retriever.query(query, top_k=top_k)

0 comments on commit 9f9a7f9

Please sign in to comment.