Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate discord app #1059

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

koch3092
Copy link
Collaborator

Description

Describe your changes in detail.

Motivation and Context

close #1054

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@koch3092 koch3092 self-assigned this Oct 15, 2024
@koch3092 koch3092 linked an issue Oct 15, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koch3092 , left some comments below

camel/bots/discord_app.py Outdated Show resolved Hide resolved
camel/bots/discord_app.py Outdated Show resolved Hide resolved
camel/bots/discord_app.py Show resolved Hide resolved
camel/bots/discord_app.py Show resolved Hide resolved
camel/bots/discord_app.py Outdated Show resolved Hide resolved
camel/bots/discord_app.py Outdated Show resolved Hide resolved
camel/bots/discord_app.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about move this part under camel/bots, and rename it from Agent into BotAgent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Agent is a ChatAgent application. If we want to design it as a BotAgent, we should put it in a module of a dedicated Agent like CodeAgent. The current Agent is just an example and is not designed specifically for Bots, such as designing its prompt, etc.

@Wendong-Fan Wendong-Fan mentioned this pull request Oct 17, 2024
13 tasks
@Wendong-Fan Wendong-Fan added this to the Sprint 14 milestone Oct 18, 2024
@Wendong-Fan Wendong-Fan merged commit 679dd28 into master Oct 18, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the 1054-feature-request-integrate-discord-app branch October 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate discord app
2 participants