Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken with latest ink version #9

Open
jescalan opened this issue Dec 22, 2023 · 1 comment · May be fixed by #10
Open

Broken with latest ink version #9

jescalan opened this issue Dec 22, 2023 · 1 comment · May be fixed by #10

Comments

@jescalan
Copy link

I know this is a real mess but bear with me:

The latest version of ink is published as an ES module, and when this package is built with tsc, it converts all of the import statements into requires, which is entirely reasonable. However, when it tries to require('ink'), it spins out, since ink is published directly as an es module without being built now.

I'm not entirely sure how this can be resolved, but poking into it - just wanted to raise the issue at least 👀
@jescalan
Copy link
Author

jescalan commented Jan 8, 2024

Update: I am working on a fix for this, intend to put it in this week. The whole package kind of needs to be rewritten to make it work, but that's fine, it's a fairly small package and shouldn't take long 😁

@jescalan jescalan linked a pull request Jan 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to work with latest version of ink jescalan/ink-markdown
1 participant
@jescalan