-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to work with latest version of ink #10
base: main
Are you sure you want to change the base?
Conversation
|
Doesn't look like changeset has been initialized, or the |
Hi, do you plan to merge it, or some additional work required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes @jescalan! I've left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Please delete this package-lock.json
file.
The repo uses yarn
not npm
.
@@ -28,28 +28,29 @@ | |||
"files": [ | |||
"./build" | |||
], | |||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: I'm not ready to make this an ES module.
I'd prefer to leave this as a CommonJS module for the time being.
I've just initialized changesets on |
Any updates on this PR? I'm looking forward to using this package with ink v4. Anything I can do to help? |
Any update regarding this PR? |
This PR updates all dependencies and makes the package work with v4 of ink 🎉
Closes #9