Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to work with latest version of ink #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jescalan
Copy link

@jescalan jescalan commented Jan 9, 2024

This PR updates all dependencies and makes the package work with v4 of ink 🎉

Closes #9

Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: 59288c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jescalan
Copy link
Author

jescalan commented Jan 9, 2024

Doesn't look like changeset has been initialized, or the .changeset folder has been gitignored. Happy to add one if it's added back but don't want to init changesets as part of this PR.

@h0x91b
Copy link

h0x91b commented Jan 22, 2024

Hi, do you plan to merge it, or some additional work required?

Copy link
Owner

@cameronhunter cameronhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @jescalan! I've left a few comments.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Please delete this package-lock.json file.

The repo uses yarn not npm.

@@ -28,28 +28,29 @@
"files": [
"./build"
],
"type": "module",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: I'm not ready to make this an ES module.

I'd prefer to leave this as a CommonJS module for the time being.

@cameronhunter
Copy link
Owner

Doesn't look like changeset has been initialized, or the .changeset folder has been gitignored. Happy to add one if it's added back but don't want to init changesets as part of this PR.

I've just initialized changesets on main

@foldsters
Copy link

Any updates on this PR? I'm looking forward to using this package with ink v4. Anything I can do to help?

@arzkar
Copy link

arzkar commented Aug 17, 2024

Any update regarding this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with latest ink version
5 participants