[FIX] monitoring_log_requests: response_status_code #468
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the response status code would not be properly logged -> fix the code
gurneyalex
force-pushed
the
16.0-fix_monitoring_log_requests
branch
from
dc94374
to
30b7335
Compare
santostelmo
approved these changes
Aug 27, 2024
Ricardoalso
reviewed
Aug 27, 2024
| info["status_code"] = response.status_code | ||
| if isinstance(response, Response) and hasattr(response, "status_code"): | ||
| info["response_status_code"] = response.status_code | ||
| else: |
There was a problem hiding this comment.
Can this not be misleading ? Or are we always sure that an inexistent status_code represents a 200 status code meaning that the request was successful 🤔
It is basically like setting "response_status_code": 200 in line 63
cyrilmanuel
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the response status code would not be properly logged -> fix the code