Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add multiregion CI badge in footer of release-please PR #2235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Aug 15, 2024

Which problem does the PR fix?

#2236

This PR adds a badge to the footer of release-please PRs that looks like this:

multiregion workflow

This will help us know at-a-glance if a release is capable of being ran with multiregion enabled.

However, this is limited. the CI that gives the badge status will only run nightly on weekdays, and tests against the snapshot images/helm charts. not specifically the helm package from the release PR.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Multiregion should be tested prior to each release
1 participant