feat: update no-version-tag rule and add version-tag rule
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
in progress
nikku
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Integrated camunda/bpmnlint-plugin-camunda-compat#174. @philippfromme looks good to me!
There is still six test failures, which I'm not sure are related or unrelated to this PR.
Edit: Confirmed the test failures are due to the bpmnlint-plugin bump. Can you have a look?
nikku
force-pushed
the
fix-version-tag
branch
from
1c9aa86
to
d24d8c6
Compare
|
Follow-up house keeping PR (can be merged independently) -> #118. |
|
I'll have a look. |
philippfromme
force-pushed
the
fix-version-tag
branch
from
d24d8c6
to
9242cff
Compare
bpmn-io-tasks
bot
added
needs review
fix: prevent double-linting of version tag field Related to camunda/camunda-modeler#4519
nikku
force-pushed
the
fix-version-tag
branch
from
9242cff
to
47573fb
Compare
nikku
approved these changes
Sep 17, 2024
philippfromme
added
the
fixed upstream
bpmn-io-tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates fix for camunda/camunda-modeler#4519 and handles the changed lint errors.
Related to camunda/camunda-modeler#4519
Requires camunda/bpmnlint-plugin-camunda-compat#174