Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump canoncialwebteam.discourse to 5.6.0 & Vanilla to 4.14.0 #347

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore: Bump canoncialwebteam.discourse to 5.6.0 & Vanilla to 4.14.0 #347

merged 1 commit into from
Jul 4, 2024

Conversation

petesfrench
Copy link
Contributor

Done

Bump canonicalwebteam.discourse to 5.6.0 and vanilla to 4.14.0

QA

  • Check nothing the changes in vanilla have not broken anything
  • Go to docs and hover over a h2 heading, see the vanilla anchor link works as expected
  • Inspect the heading and see there are no trailing numbers on the heading

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12934

@webteam-app
Copy link

Demo

Jenkins

demos.haus

mtruj013
mtruj013 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petesfrench petesfrench merged commit b9ba16e into main Jul 4, 2024
5 of 6 checks passed
@petesfrench petesfrench deleted the wd-12934 branch July 4, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtruj013 mtruj013 mtruj013 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petesfrench @webteam-app @mtruj013