Allow use actions/config/metadata in charmcraft.yaml #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syu-w
force-pushed
the
move2charmcraft
branch
3 times, most recently
from
be67c80
to
325b211
Compare
lengau
requested changes
Jul 5, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
reviewed
Jul 7, 2023
lengau
approved these changes
Jul 7, 2023
New metadata keys can be used in charmcraft.yaml if metadata.yaml not exists. tests: fix windows incomplete escape config: convert undocumented maintainer models: fix peers specs pack: bundle does not need metadata.yaml in zip config: convert new metadata to legacy metadata when export config: allow bundle without metadata.yaml
New actions keys can be used in charmcraft.yaml if actions.yaml not exists.
config keys can be used in charmcraft.yaml if config.yaml not exists.
Use new prepare_*_yaml for tests.
lengau
reviewed
Jul 7, 2023
| DISPATCH_FILENAME, | ||
| HOOKS_DIRNAME, | ||
| ] | ||
| CHARM_FILES = frozenset( |
There was a problem hiding this comment.
The only downside is some tests are order sensitive when this changed to unordered, had to add a workaround.
lengau
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use actions/config/metadata in
charmcraft.yamlwhen corresponding yaml file does not exist.Metadata in
charmcraft.yamlalso must be new keys defined in spec ST087.CRAFT-1747
CRAFT-1788
CRAFT-1789