fix: allow fetch-libs to work without logging in #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
changed the title
lengau
force-pushed
the
work/CRAFT-2878-no-login
branch
from
db748e8
to
e1ec791
Compare
tigarmo
approved these changes
Jun 13, 2024
| def setup(self) -> None: | ||
| """Set up the store service.""" | ||
| super().setup() | ||
| self.anonymous_client = store.AnonymousClient( |
There was a problem hiding this comment.
is this feature (anonymous access) something that we should (eventually) upstream in BaseStoreService?
There was a problem hiding this comment.
Eventually once it's a craft_store feature, yeah.
mr-cal
approved these changes
Jun 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681