Add security settings #25
Conversation
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
2 times, most recently
from
8aaf6a8
to
e0c841d
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
e0c841d
to
97dab0f
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
a695c57
to
c64c26d
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
4bb18a7
to
a6f71ba
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
a6f71ba
to
5ba423f
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
7f63791
to
8cdea45
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
5c4a33f
to
7ac4ac4
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushny/add_security_manifest
branch
from
7ac4ac4
to
bbff857
Compare
dmitry-ratushnyy
requested review from
jardon
and removed request for
jardon
| @@ -16,6 +16,7 @@ jobs: | |||
| run: | | |||
| sudo snap install yq | |||
| sudo snap install rockcraft --classic --edge --revision=687 | |||
| sudo snap install charmcraft --classic --revision 1349 | |||
There was a problem hiding this comment.
Noob question: why different charmcraft here than in integration?
There was a problem hiding this comment.
AFAIK it is actually the same version, but in this case we install it while in case of integration test we update the installed one
| # enable security monitoring | ||
| rocks=usr/share/rocks/ | ||
| mkdir -p ${rocks} | ||
| ## for deb packages |
There was a problem hiding this comment.
nit can we have enters after the comments
There was a problem hiding this comment.
I can try but linter was complaining about those
There was a problem hiding this comment.
hmm maybe we can copy the linter from opensearch? they seem to have less problems, and then you could have the dpkg command the way you originally intended?
(doesn't have to be now) but would be good long term if we had our linters alligned across products on the NoSQL team
There was a problem hiding this comment.
looks like opensearch rock does not have a linter (if I am not missing anything)
The goal of this PR is:
1.Add required security Manifests to ROCK
2. Remove util-linux deb since it is packaged in the snap that the ROCK is based off