Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivy #35

Open
wants to merge 5 commits into
base: 8.0-22.04
Choose a base branch
from
Open

Add trivy #35

wants to merge 5 commits into from

Conversation

zmraul
Copy link

@zmraul zmraul commented Nov 9, 2023

Test trivy action

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@carlcsaposs-canonical
Copy link
Contributor

@paulomach is this PR relevant today (given that it's from 2023-11)?

if so:
is there documentation somewhere about:

  • what we're trying to accomplish with this
  • who will be responsible for monitoring alerts & how they will do that
    ?

also, would it be possible rebase this PR so that trivy is added to the reusable workflows?

@paulomach
Copy link
Contributor

@paulomach is this PR relevant today (given that it's from 2023-11)?

I believe it is. The fact that it's old is about us missing it, instead of it not being important.

if so: is there documentation somewhere about:

* what we're trying to accomplish with this

Ensuring the rock is up-to-date for CVE. Nowadays we are just rebuilding it on our need (e.g. outdated snap) and not when some of the content has vulnerability

* who will be responsible for monitoring alerts & how they will do that
  ?

The duty engineer. Trivy alers will be shown on repo's security report

also, would it be possible rebase this PR so that trivy is added to the reusable workflows?

That's not a bad idea, since all rocks would benefit. @zmraul want to venture on that?

@carlcsaposs-canonical
Copy link
Contributor

I believe other teams may be working on other solutions in parallel that are more aligned with other future plans

and that we may be duplicating their efforts here

@taurus-forever
Copy link
Contributor

Will talk Enrico the next week. AFAIK BigData uses Trivy.... and maybe we should add it to dpw.

P.S. we need to retriger it at least:
https://github.com/canonical/charmed-mysql-rock/actions/runs/6809760169/job/18516809933

The logs for this run have expired and are no longer available.

@taurus-forever
Copy link
Contributor

@paulomach
Copy link
Contributor

@taurus-forever
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants